1.1.7 — diff review from 1.1.4 only (older version)
From zcash/rust-ecosystem copy of zcash/zcash. By Jack Grigg.
These reviews are from cargo-vet. To add your review, set up cargo-vet
and submit your URL to its registry.
The current version of ThreadLocal is 1.1.8.
1.1.7 — diff review from 1.1.4 only (older version)
From zcash/rust-ecosystem copy of zcash/zcash. By Jack Grigg.
1.1.7 — diff review from 1.0.1 only (older version)
From google/supply-chain copy of fuchsia. By David Koloski.
Reviewed on https://fxrev.dev/906819
1.1.7 (older version)
From kornelski/crev-proofs copy of git.savannah.gnu.org.
Packaged for Guix (crates-io)
1.1.4 (older version)
From bytecodealliance/wasmtime. By Pat Hickey.
uses unsafe to implement thread local storage of objects
cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.
This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…
This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…
Negligible unsoundness or average soundness.
Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-2
Mild unsoundness or suboptimal soundness.
Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-3
Extreme unsoundness.
Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-4
May have been packaged automatically without a review
This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev
.
The current version of ThreadLocal is 1.1.8.
0.3.6 (older version) Thoroughness: Medium Understanding: Medium
by BurntSushi on 2019-08-22
This crate was written by Amanieu d'Antras in response to my efforts to make thread safe caching in the regex crate faster. The way to think about it is "dynamic" thread local storage.
The crate does use a fair amount of unsafe, and the reason for this is to minimize latency as much as is possible. Each use of unsafe isn't particularly tricky---it's mostly managing atomic access to a hash table. With that said, it would be nice if each use of unsafe had a comment explaining/justifying it. There are some comments scattered about making reasonable arguments, but more would be good.
This crate did have an issue a while back where if a program used the same regex (for example) many times from many short lived threads, then the cached data could grow without bound. Amanieu patched that issue a while back by reusing thread ids. A thread id is tracked using normal TLS, which is dropped when the thread is destroyed.
I gave this crate a rating of positive because I cannot identify any issues after reviewing the code, although, I am not completely certain that there are no issues because of the use of unsafe code.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.
To review the actual code of the crate, it's best to use cargo crev open thread_local
. Alternatively, you can download the tarball of thread_local v1.1.8 or view the source online.
New
unsafe
usage:deallocate_bucket
, to replace aMutex::lock
with acompare_exchange
.#[thread_local] static mut Option<Thread>
on nightly.