This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of Syslog is 5.0.0.

4.0.1 (older version) Rating: Positive Thoroughness: Medium Understanding: Medium

by on 2019-11-20

  • Definitions used with the error_chain crate; no unsafe.

  • Defines a type for Syslog facilties and the associated constants. No unsafe.

  • Message formatting incl. structured data. No unsafe.
  • Formatting looks conformant to RFC 5424.

  • Initialization code, socket stuff, and user facing wrappers.
  • One unsafe call to getpid(2); harmless.