Lib.rs

› Serde › Reviews

These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.

The current version of Serde is 1.0.198.

1.0.197 (older version) safe-to-deploy, does-not-implement-crypto, ub-risk-2

From google/supply-chain copy of chromium. By Lukasz Anforowicz.

Grepped for -i cipher, -i crypto, 'fs', 'net', 'unsafe'.

There were some hits for net, but they were related to serialization and not actually opening any connections or anything like that.

There were 2 hits of unsafe when grepping:

  • In fn as_str in impl Buf
  • In fn serialize in impl Serialize for net::Ipv4Addr

Unsafe review comments can be found in https://crrev.com/c/5350573/2 (this review also covered serde_json_lenient).

Version 1.0.130 of the crate has been added to Chromium in https://crrev.com/c/3265545. The CL description contains a link to a (Google-internal, sorry) document with a mini security review.

cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.

safe-to-deploy (implies safe-to-run)

This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…

safe-to-run

This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…

does-not-implement-crypto (implies crypto-safe)

Inspection reveals that the crate in question does not attempt to implement any cryptographic algorithms on its own.

Note that certification of this does not require an expert on all forms of cryptography: it's expected for crates we import to be "good enough" citizens, so they'll at least be forthcoming if they try to implement something cryptographic. When in doubt, please ask an expert.

crypto-safe
Implied by other criteria

All crypto algorithms in this crate have been reviewed by a relevant expert.

Note: If a crate does not implement crypto, use does-not-implement-crypto, which implies crypto-safe, but does not require expert review in order to audit for.

ub-risk-2 (implies ub-risk-3)

Negligible unsoundness or average soundness.

Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-2

ub-risk-3 (implies ub-risk-4)
Implied by other criteria

Mild unsoundness or suboptimal soundness.

Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-3

ub-risk-4
Implied by other criteria

Extreme unsoundness.

Full description of the audit criteria can be found at https://github.com/google/rust-crate-audits/blob/main/auditing_standards.md#ub-risk-4

unknown

May have been packaged automatically without a review

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of Serde is 1.0.198.

1.0.136 (older version) Rating: Positive Thoroughness: Low Understanding: Medium

Approved without comment by oh-wind on 2022-03-20

1.0.103 (older version) Rating: Positive Thoroughness: Low Understanding: Medium

Approved without comment by gitlab.com/KonradBorowski on 2019-12-11

1.0.101 (older version) Rating: Strong Positive Thoroughness: Low Understanding: Medium

Approved without comment by dpc on 2019-10-12

Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open serde. Alternatively, you can download the tarball of serde v1.0.198 or view the source online.