This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of riot-sys is 0.7.8.

0.7.0 (older version) Rating: Positive Thoroughness: Low Understanding: High

by gitlab.com/chrysn on 2022-01-13

Own-crate review. Does what it says on the packaging. Not safe in a 'safe to use' sense, but then again this is not to be expected from a -sys crate (all functions are declared unsafe).


Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball. To review the actual code of the crate, it's best to use cargo crev open riot-sys. Alternatively, you can download the tarball of riot-sys v0.7.8.