10.7.0 — diff review from 10.6.1 only (older version)
From zcash/rust-ecosystem copy of zcash/zcash. By str4d.
These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.
The current version of raw-cpuid is 11.0.1.
10.7.0 (older version)
From kornelski/crev-proofs copy of git.savannah.gnu.org.
Packaged for Guix (crates-io)
10.6.1 — diff review from 10.6.0 only (older version)
From zcash/rust-ecosystem copy of zcash/zcash. Audited without comment by Jack Grigg.
cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.
- safe-to-deploy (implies safe-to-run)
-
This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…
- safe-to-run
Implied by other criteria
This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…
- unknown
-
May have been packaged automatically without a review
These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
The current version of raw-cpuid is 11.0.1.
10.2.0 (older version) Thoroughness: Low Understanding: Medium
by niklasf on 2021-10-17
All soundness issues have been fixed and unsafe code is no longer used casually. Some transmutes from raw CPUID data to structs remain, but now with comments explaining why they are safe.
8.1.2 (older version) Thoroughness: High Understanding: Medium
by niklasf on 2021-01-17
Show review…
The crate has multiple soundness issues.
Most importantly, it performs transmutes that are most likely unsound or at best incorrect (https://github.com/gz/rust-cpuid/issues/40).
Further, for machines that do not support CPUID (arguably rare, when ignoring SGX), it incorrectly exposes the unsafe core::arch::__cpuid_count() as a safe function. (The safety requirement is that the CPUID instruction is supported, https://github.com/gz/rust-cpuid/issues/41).
Soundness issues aside, there are some minor issues.
- The crate introduces considerable complexity (including FFI), to support old rustc versions (https://github.com/gz/rust-cpuid/pull/38).
- Some casual use of unsafe code that can be rewritten to be safe (https://github.com/gz/rust-cpuid/pull/39).
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.
To review the actual code of the crate, it's best to use cargo crev open raw-cpuid. Alternatively, you can download the tarball of raw-cpuid v11.0.1 or view the source online.
Appears to be a move-only change in display code to expose an internal API. I did not verify that the change was move-only, but there is no unsafe code affected.