Code reviews of the OwningRef crate // Lib.rs

RUSTSEC-2022-0040 on 2022-01-26: Multiple soundness issues in owning_ref

OwningRef::map_with_owner is unsound and may result in a use-after-free.
OwningRef::map is unsound and may result in a use-after-free.
OwningRefMut::as_owner and OwningRefMut::as_owner_mut are unsound and may result in a use-after-free.
The crate violates Rust's aliasing rules, which may cause miscompilations on recent compilers that emit the LLVM noalias attribute.

safer_owning_ref is a replacement crate which fixes these issues. No patched versions of the original crate are available, and the maintainer is unresponsive.

https://github.com/Kimundi/owning-ref-rs/issues/49

https://github.com/Kimundi/owning-ref-rs/issues/61

https://github.com/Kimundi/owning-ref-rs/issues/71

https://github.com/Kimundi/owning-ref-rs/issues/77

GHSA-9qxh-258v-666c

These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

0.4.1 (current) Rating: Negative Thoroughness: None Understanding: None

by kornelski on 2022-01-27

OwningRefMut::{as_owner, as_owner_mut} and OwningRef::as_owner are reportedly unsound.

Issue: Medium (github.com/noamtashma/owning-ref-unsoundness)

The current version of OwningRef is 0.4.1.

0.4.0 (older version) Rating: Positive Thoroughness: Low Understanding: Low

Approved without comment by dpc on 2019-11-11

These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.

0.4.1 (current) safe-to-run, does-not-implement-crypto

From google/supply-chain copy of chromium. Audited without comment by ChromeOS.

0.4.1 (current) unknown

From kornelski/crev-proofs copy of git.savannah.gnu.org.

Packaged for Guix (crates-io)

cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.

safe-to-run

This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…

does-not-implement-crypto (implies crypto-safe)

Inspection reveals that the crate in question does not attempt to implement any cryptographic algorithms on its own.

Note that certification of this does not require an expert on all forms of cryptography: it's expected for crates we import to be "good enough" citizens, so they'll at least be forthcoming if they try to implement something cryptographic. When in doubt, please ask an expert.

crypto-safe

Implied by other criteria

All crypto algorithms in this crate have been reviewed by a relevant expert.

Note: If a crate does not implement crypto, use does-not-implement-crypto, which implies crypto-safe, but does not require expert review in order to audit for.

unknown

May have been packaged automatically without a review

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball. To review the actual code of the crate, it's best to use cargo crev open owning_ref. Alternatively, you can download the tarball of owning_ref v0.4.1 or view the source online.