0.1.13 (older version) Thoroughness: Medium Understanding: Medium
by dpc on 2018-12-19
This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev
.
The current version of NoDrop is 0.1.14.
0.1.13 (older version) Thoroughness: Medium Understanding: Medium
by dpc on 2018-12-19
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.
To review the actual code of the crate, it's best to use cargo crev open nodrop
. Alternatively, you can download the tarball of nodrop v0.1.14.
Some
unsafe
, but LGTM