Code review of the matrix-sdk crate // Lib.rs

This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of matrix-sdk is 0.7.1.

0.2.0 (older version) Rating: Positive Thoroughness: Medium Understanding: Medium

by MTRNord on 2021-02-01

=Review Matrix-SDK=

==Cargo audit==

Dependency affected by smallvec bug https://rustsec.org/advisories/RUSTSEC-2021-0003
Mockito dependency uses unmaintained crate "difference"
Directly uses unmaintained "dirs" crate
Through a deep chain of deps uses "net2" which is unmaintained
Indirectly uses "stdweb"

==Cargo clippy==

All green

==Cargo test==

All green

==Code==

Lots of well documentation
Easy to reach community channel to ask questions
Many tests which all are green
Multiple good documented examples

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball. To review the actual code of the crate, it's best to use cargo crev open matrix-sdk. Alternatively, you can download the tarball of matrix-sdk v0.7.1 or view the source online.