Lib.rs

› Inkwell › Reviews

This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

The current version of Inkwell is 0.4.0.

0.1.0-beta.2 (older version) Rating: Negative Thoroughness: Low Understanding: Medium

by programmerjake on 2021-04-14

Found some unsound code, reported in #241

Going through the code, there are many places where non-public functions are not marked unsafe even when they exhibit UB if given garbage input. Since those functions are not publically visible, external users can't directly cause UB from safe code, but I'd consider that a code style issue. Reported in #244

There are several places where lifetimes seem to have been ignored, unnecessarily restricting users. Reported in #243

ExecutionEngine is not thread-safe, even though the underlying LLVM type is. Reported in #242

The documentation for TargetMachine::write_to_file is misleading and incorrect. Reported in #240

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball. To review the actual code of the crate, it's best to use cargo crev open inkwell. Alternatively, you can download the tarball of inkwell v0.4.0 or view the source online.