0.3.1 (current) Thoroughness: Medium Understanding: High
by MaulingMonkey on 2019-09-24
This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev
.
0.3.1 (current) Thoroughness: Medium Understanding: High
by MaulingMonkey on 2019-09-24
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.
To review the actual code of the crate, it's best to use cargo crev open glsl-include
. Alternatively, you can download the tarball of glsl-include v0.3.1 or view the source online.
Handle basic #include s for GLSL.
Pros:
Cons:
#file
directives emitted#include
, must pre-register all possible includes.0.3.1
include(path, into_string)
.