0.4.16 (older version) Thoroughness: Medium Understanding: Low
by MaulingMonkey on 2019-09-17
These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
The current version of dinghy-build is 0.7.1.
0.4.15 (older version) Thoroughness: Medium Understanding: Low
by MaulingMonkey on 2019-09-17
Show review…
0.4.15: Trivial version bumps. 0.4.14: Trivial version bumps, style changes. 0.4.13: Trivial version bumps. 0.4.12: Trivial version bumps. 0.4.11 Some of the build/path stuff seems a little off... but might be correct? All safe code, no security problems.
Reviewed:
src\build_env.rs +1
src\build.rs +1
src\lib.rs 0
102 Is this really correct for specifying the *host* environment?
105 ..
src\utils.rs 0
14 Isn't this generating /../../../ ? Doesn't seem right...
Cargo.toml +1
Cargo.toml.orig +1
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.
To review the actual code of the crate, it's best to use cargo crev open dinghy-build. Alternatively, you can download the tarball of dinghy-build v0.7.1 or view the source online.
0.4.16: Trivial version bumps. 0.4.15: Trivial version bumps. 0.4.14: Trivial version bumps, style changes. 0.4.13: Trivial version bumps. 0.4.12: Trivial version bumps. 0.4.11 Some of the build/path stuff seems a little off... but might be correct? All safe code, no security problems.
Reviewed: