0.4.16 (older version) Thoroughness: Low Understanding: Medium
by MaulingMonkey on 2019-09-17
These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev
.
The current version of cargo-dinghy is 0.6.8.
0.4.16 (older version) Thoroughness: Low Understanding: Medium
by MaulingMonkey on 2019-09-17
0.4.15 (older version) Thoroughness: Low Understanding: Medium
by MaulingMonkey on 2019-09-17
0.4.15: Trivial version bumps. 0.4.14: Trivial version bumps, mass reformatting. 0.4.13: Trivial version bumps. 0.4.12: Trivial version bumps. 0.4.11: Nice and solid looking code. 100% safe code.
Reviewed: src\cli.rs: +1 src\main.rs: +1 151 run_lldb Nonterminating loops are problematic, but I think the side effects here should make this work OK? (see https://github.com/rust-lang/rust/issues/28728 ) Cargo.toml: +1 Cargo.toml.orig: +1 13 readme path references unpackaged readme
TIL: Using traits to extend clap::App so flags can be reused per-subcommand is interesting.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.
To review the actual code of the crate, it's best to use cargo crev open cargo-dinghy
. Alternatively, you can download the tarball of cargo-dinghy v0.6.8 or view the source online.
0.4.16: Trivial version bumps. 0.4.15: Trivial version bumps. 0.4.14: Trivial version bumps, mass reformatting. 0.4.13: Trivial version bumps. 0.4.12: Trivial version bumps. 0.4.11: Nice and solid looking code. 100% safe code.
Reviewed: src\cli.rs: +1 src\main.rs: +1 151 run_lldb Nonterminating loops are problematic, but I think the side effects here should make this work OK? (see https://github.com/rust-lang/rust/issues/28728 ) Cargo.toml: +1 Cargo.toml.orig: +1 13 readme path references unpackaged readme
TIL: Using traits to extend clap::App so flags can be reused per-subcommand is interesting.