These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

0.1.3 (current) Rating: Positive Thoroughness: Medium Understanding: High

by MaulingMonkey on 2020-10-11

[Full Audit] Parses JSON aseprite exports

Pros:

  • Looks fairly exhaustive, self contained
  • No direct disk I/O

Cons:

  • Exahustively matchable structs make most version bumps technically breaking changes
  • Requires non-default export options (fixed in an unmerged PR)
  • Enum deserialization is brittle when it comes to new options
  • Limited maintainence

The current version of aseprite is 0.1.3.

0.1.2 (older version) Rating: Positive Thoroughness: Medium Understanding: High

by MaulingMonkey on 2020-10-11

Show review…

[Full Audit] Parses JSON aseprite exports

Pros:

  • Looks fairly exhaustive, self contained
  • No direct disk I/O

Cons:

  • Exahustively matchable structs make most version bumps technically breaking changes
  • Requires non-default export options (fixed in an unmerged PR)
  • Enum deserialization is brittle when it comes to new options
  • Limited maintainence

0.1.1 (older version) Rating: Negative Thoroughness: Medium Understanding: High

by MaulingMonkey on 2020-10-11

Show review…

Private fields make this unusable until 0.1.2

0.1.0 (older version) Rating: Negative Thoroughness: Medium Understanding: High

by MaulingMonkey on 2020-10-11

Show review…

Private fields make this unusable until 0.1.2