1.0.2 (current) Thoroughness: High Understanding: Medium
by Minoru on 2021-04-28
These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
The current version of adler is 1.0.2.
0.2.3 (older version) Thoroughness: Low Understanding: Medium
Approved without comment by kornelski on 2020-07-14
These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.
1.0.2 (current)
From bytecodealliance/wasmtime. By Alex Crichton.
This is a small crate which forbids unsafe code and is a straightforward implementation of the adler hashing algorithm.
1.0.2 (current)
From kornelski/crev-proofs copy of salsa.debian.org.
Packaged for Debian (stable). Changelog:
- Team upload.
- Package adler 1.0.2 from crates.io using debcargo 2.5.0
- Establish baseline for tests.
1.0.2 (current)
From kornelski/crev-proofs copy of git.savannah.gnu.org.
Packaged for Guix (crates-io)
cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.
- safe-to-deploy (implies safe-to-run)
-
This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…
- safe-to-run
-
This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…
- unknown
-
May have been packaged automatically without a review
Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.
To review the actual code of the crate, it's best to use cargo crev open adler. Alternatively, you can download the tarball of adler v1.0.2 or view the source online.
This is an implementation of Adler-32 checksum. It has no
unsafe, and the code is quite simple. The only complicated part is the algorithm itself, but there is a big comment explaining what's going on, and the structure of the code matches the explanation. I can't vouch the implementation is bug-free, but I'm sure it's sound and isn't malicious.Thoroughness is "high" because I read the whole crate quite attentively, but understanding is still "medium" since I didn't quite follow the math that enables vectorization in this crate.