This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

0.2.6 (current) Rating: Negative Thoroughness: None Understanding: None

by dpc on 2020-01-16

There have been numerous reports of authors ignoring soundness issues in actix ecosystem.

See example: https://www.reddit.com/r/rust/comments/epszt7/actixnet_unsoundness_patch_is_boring/

So I'm giving a proactive negative rating, and feel free to contact me if there are good reasons to change it - eg. if the issues have been addressed and maintainers are commited to taking memory safety and security seriously.


Lib.rs has been able to verify that all files in the crate's tarball are in the crate's repository with a git tag matching the version. Please note that this check is still in beta, and absence of this confirmation does not mean that the files don't match.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories, so there is a possibility that published crates have a misleading repository URL, or contain different code from the code in the repository.

To review the actual code of the crate, it's best to use cargo crev open actix-net. Alternatively, you can download the tarball of actix-net v0.2.6 or view the source online.