1.2.0 (current) Thoroughness: Medium Understanding: High
by yvt on 2021-09-12
These reviews are from Crev, a distributed system for code reviews. To add your review, set up cargo-crev
.
1.2.0 (current) Thoroughness: Medium Understanding: High
by yvt on 2021-09-12
The current version of stable_deref_trait is 1.2.0.
1.1.1 (older version) Thoroughness: Medium Understanding: High
by gitlab.com/KonradBorowski on 2019-10-02
All implementations are correct, trait requirements seem fine and usable for crates like rental (unlike std::pin::Pin).
These reviews are from cargo-vet. To add your review, set up cargo-vet
and submit your URL to its registry.
1.2.0 (current)
From google/supply-chain copy of chromium. Audited without comment by George Burgess IV.
1.2.0 (current)
From kornelski/crev-proofs copy of git.savannah.gnu.org.
Packaged for Guix (crates-io)
cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.
This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…
Inspection reveals that the crate in question does not attempt to implement any cryptographic algorithms on its own.
Note that certification of this does not require an expert on all forms of cryptography: it's expected for crates we import to be "good enough" citizens, so they'll at least be forthcoming if they try to implement something cryptographic. When in doubt, please ask an expert.
All crypto algorithms in this crate have been reviewed by a relevant expert.
Note: If a crate does not implement crypto, use does-not-implement-crypto
,
which implies crypto-safe
, but does not require expert review in order to
audit for.
May have been packaged automatically without a review
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.
To review the actual code of the crate, it's best to use cargo crev open stable_deref_trait
. Alternatively, you can download the tarball of stable_deref_trait v1.2.0 or view the source online.
The sole purpose of this crate is define the two traits
StableDeref
andCloneStableDeref
and provide their implementations on built-in and standard library types. These marker traits define requirements on the stability of theDeref
results of the ascribed type.The trait requirements are defined clearly. Although (to my knowledge) some of the standard library types marked with these traits don't explicitly or indirectly say in their documentation that the requirements specified by these traits are guaranteed to be upheld for these types, it's correct for the current version of Rust and any possible sane reimplementation of the standard library, and one can reasonably expect that it will remain so in future versions.