0.28.1 (older version)
From kornelski/crev-proofs copy of salsa.debian.org.
These reviews are from cargo-vet. To add your review, set up cargo-vet and submit your URL to its registry.
The current version of gimli is 0.30.0.
0.28.0 — diff review from 0.27.3 only (older version)
From google/supply-chain copy of chromium. Audited without comment by George Burgess IV.
0.28.0 — diff review from 0.27.3 only (older version)
From bytecodealliance/wasmtime. By Alex Crichton.
Still looks like a good DWARF-parsing crate, nothing major was added or deleted
and no unsafe code to review here.
0.27.3 — diff review from 0.27.2 only (older version)
From zcash/rust-ecosystem copy of zcash/zcash. Audited without comment by str4d.
0.27.2 — diff review from 0.27.0 only (older version)
From zcash/rust-ecosystem copy of zcash/zcash. Audited without comment by Jack Grigg.
0.27.2 (older version)
From kornelski/crev-proofs copy of git.savannah.gnu.org.
Packaged for Guix (crates-io)
cargo-vet does not verify reviewers' identity. You have to fully trust the source the audits are from.
- safe-to-run
-
This crate can be compiled, run, and tested on a local workstation or in controlled automation without surprising consequences. More…
- does-not-implement-crypto (implies crypto-safe)
-
Inspection reveals that the crate in question does not attempt to implement any cryptographic algorithms on its own.
Note that certification of this does not require an expert on all forms of cryptography: it's expected for crates we import to be "good enough" citizens, so they'll at least be forthcoming if they try to implement something cryptographic. When in doubt, please ask an expert.
- crypto-safe
Implied by other criteria
All crypto algorithms in this crate have been reviewed by a relevant expert.
Note: If a crate does not implement crypto, use
does-not-implement-crypto, which impliescrypto-safe, but does not require expert review in order to audit for.- safe-to-deploy (implies safe-to-run)
-
This crate will not introduce a serious security vulnerability to production software exposed to untrusted input. More…
- unknown
-
May have been packaged automatically without a review
This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.
The current version of gimli is 0.30.0.
0.15.0 (older version) Thoroughness: Low Understanding: Medium
by MaulingMonkey on 2019-07-28
Looks nice and solid. Well documented, well tested, code coverage, safe + sound. Large crate - so I haven't taken the time to thoroughly audit everything - but I have at least skimmed over all code. I've written some of my own partial DWARF parser in C++ in the past... parts look appropriately familiar.
Detail
| File | Rating | Notes |
|---|---|---|
| benches/bench.rs | +1 | fs |
| examples/dwarfdump.rs | +1 | fs |
| fixtures/self/* | unreviewed binary data (used in test fixtures, probably OK) | |
| fixtures/self/README.md | +1 | |
| releases/friends.sh | +1 | |
| releases/release-announcement-template.md | +1 | |
| src/abbrev.rs | +1 | |
| src/aranges.rs | +1 | |
| src/cfi.rs | +1 | |
| src/constants.rs | +1 | |
| src/endianity.rs | +1 | |
| src/leb128.rs | +1 | |
| src/lib.rs | +1 | |
| src/line.rs | +1 | |
| src/loc.rs | +1 | |
| src/lookup.rs | +1 | |
| src/op.rs | +1 | |
| src/parser.rs | +1 | |
| src/pubnames.rs | +1 | |
| src/pubtypes.rs | +1 | |
| src/ranges.rs | +1 | |
| src/reader.rs | +1 | |
| src/str.rs | +1 | |
| src/test_util.rs | +1 | |
| src/unit.rs | +1 | |
| tests/parse_self.rs | +1 | |
| .cargo-ok | +1 | |
| .gitignore | +1 | |
| .travis.yml | 0 | I haven't reviewed travis-cargo |
| Cargo.toml | +1 | |
| Cargo.toml.orig | +1 | |
| CONTRIBUTING.md | +1 | |
| coverage | +1 | |
| format | +1 | |
| LICENSE-APACHE | +1 | |
| LICENSE-MIT | +1 | |
| README.md | +1 | |
| rustfmt.toml | +1 |
| Other | Rating | Notes |
|---|---|---|
| unsafe | +1 | Single match unsafe { memmap::Mmap::map(&file) } |
| fs | +1 | Safe, only used in benches/examples/tests |
| io | +1 | Some io::{stderr, Error, Write} - all sane |
| docs | +1 | Lots of 'em! |
| tests | +1 | Lots of 'em! |
TIL
travis-cargo
Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.
To review the actual code of the crate, it's best to use cargo crev open gimli. Alternatively, you can download the tarball of gimli v0.30.0 or view the source online.
Only in debcargo (unstable). Changelog: