Code review of the Current crate // Lib.rs

This review is from Crev, a distributed system for code reviews. To add your review, set up cargo-crev.

0.1.2 (current) Rating: Negative Thoroughness: Medium Understanding: Medium

by git.sr.ht/~icefox on 2019-08-30

Dangerous mutable state shenanigans that should never be necessary.

Crates in the crates.io registry are tarball snapshots uploaded by crates' publishers. The registry is not using crates' git repositories. There is absolutely no guarantee that the repository URL declared by the crate belongs to the crate, or that the code in the repository is the code inside the published tarball.

To review the actual code of the crate, it's best to use cargo crev open current. Alternatively, you can download the tarball of current v0.1.2 or view the source online.